Laravel get data out of foreach loop

Question

The below code shows the error (on the line if ($response) {):

Undefined variable: response

I am checking the if condition inside the foreach because I wanted to check whether each id in the UserEnabledNotifications table exists in notifications table. Also dump($response); inside the if condition of foreach shows data.

Can I get the data in $response outside the foreach loop? What shall I try?

$notificationData = UserEnabledNotifications::all();

foreach ($notificationData->where('status', 'true') as $user => $value) {
    if (Notifications::where('userEnabledNotificationsId', $value['id'])->exists() == false) {
        $notificationTypeName = NotificationTypes::where('id', $value['notificationTypesId'])
            ->value('notificationTypeName');

        $userData = User::where('id', $value['userId'])
            ->get()
            ->toArray();

        $data = [];

        $data['notificationTypesId'] = $value['notificationTypesId'];
        $data['notificationTypeName'] = $notificationTypeName;
        $data['userId'] = $value['userId'];
        $data['email'] = $userData[0]['email'];
        $data['recipientName'] = $userData[0]['FullName'];
        $data['userEnabledNotificationsId'] = $value['id'];

        $response = Notifications::create($data);
        //dump($response);

        $tags[] = $response;
    }
}

if ($response) {
    return response()->json([
        'message' => 'success',
        'data' => $tags,
        'statusCode' => 200,
        'status' => 'success'
    ], 200);
}

score 2 · Accepted Answer · answered Aug 31 '21 at 06:48

2

You define $response in first if body but you need $response = null above that.

answered Aug 31 '21 at 06:48

knubbe

1,132
2
12
21

Krish Yadav · Answer 2 · 2021-08-31T07:50:46.363

You might create a private or protected variable, and put it outside, and then access it directly or via functions

$notificationData = UserEnabledNotifications::all();
private $reponse = null;

foreach ($notificationData->where('status', 'true') as $user => $value) {

   if(Notifications::where('userEnabledNotificationsId',$value['id'])->exists()==false){
                      
      $notificationTypeName = NotificationTypes::where('id', $value['notificationTypesId'])->value('notificationTypeName');
      
      $userData = User::where('id', $value['userId'])->get()->toArray();
      
      $data = [];
      $data['notificationTypesId'] = $value['notificationTypesId'];
      $data['notificationTypeName'] = $notificationTypeName;
      $data['userId'] = $value['userId'];
      $data['email'] = $userData[0]['email'];
      $data['recipientName'] = $userData[0]['FullName'];
      $data['userEnabledNotificationsId'] = $value['id'];
      $response = Notifications::create($data);
      
      $tags[] =  $response;
    }      
  }  
  if ($response) {
          return response()->json([
                    'message' => 'success',
                    'data' => $tags,
                    'statusCode' => 200,
                    'status' => 'success'
                ], 200);
  }

But now each place you would need to check whether responses are null or not.

Why private or protected or public?

Check this answer : What is the difference between public, private, and protected?

I quote

public scope to make that property/method available from anywhere, other classes, and instances of the object.

private scope when you want your property/method to be visible in its own class only.

protected scope when you want to make your property/method visible in all classes that extend current class including the parent class.

That would still return the same error, nothing really changed — brombeer, Aug 31 '21 at 06:51
`private $response;` line shows `syntax error, unexpected private` — , Aug 31 '21 at 07:31
@Mege can you show the code just above this line, maybe you are not closing something — Krish Yadav, Aug 31 '21 at 07:38
Am closing everything. this whole code is given inside a function in a class. Is that the problem? like this - `class UserNotificationsController extends Controller { public function insert(Request $request) {` — , Aug 31 '21 at 07:44
No, it should not be a problem, I have updated the code with $response = null, try now — Krish Yadav, Aug 31 '21 at 07:50
that again shows the same error - `syntax error, unexpected private` — , Aug 31 '21 at 08:01

score 0 · Answer 3 · answered Aug 31 '21 at 10:30

0

Simply declare a null or an empty array in a $response variable and you will be able to get the data out of the loop!

answered Aug 31 '21 at 10:30

runtimeTerror

398
3
14

Laravel get data out of foreach loop

3 Answers3

Why private or protected or public?