0

This is fairly straight forward, but I can't figure out what the problem is. I am trying to access environment variables from application.properties but when I do so like this:

import org.springframework.core.env.Environment;

public class MailService {

    @Autowired
    private static Environment env;

...
...
...
public static void send(){
        System.out.println("env {}" + env.getProperty("AWS_ACCESS_KEY_ID"));
}

Then I get a NullPointerException. So what is going on? Why am I getting an error. Here is my application.properties file with fake values:

AWS_ACCESS_KEY_ID="Asdsds"
AWS_SECRET_KEY="sdsdsdsdsdsd"
mcool
  • 457
  • 4
  • 29
  • Looks like the `env` variable is null. Oh, and probably it is bad practice or doesn't even have an effect to autowire a static variable: https://stackoverflow.com/questions/1018797/can-you-use-autowired-with-static-fields – jmizv Nov 05 '21 at 11:48
  • Any idea why? This is how i have seen examples online do it – mcool Nov 05 '21 at 11:50

2 Answers2

1

Autowired works only on class instances managed by Spring. The value is injected after the constructor. Your class isn't managed by Spring and your environment property is static.

Something like this will work:

@Service // Will be instantiated by spring
public class MailService {
    private static Environment env;

    @Autowired // This will be called after instantiation
    public void initEnvironment(Environment env){
        MailService.env = env;
    }

    public static void send(){
        // NullPointerException will be thrown if this method is called
        // before Spring created the MailService instance
        System.out.println("env {}" + env.getProperty("AWS_ACCESS_KEY_ID"));
    }
}

You should avoid using static method if you want access to object managed by Spring.

Instead let Spring manage all your class instances and inject your service when you need it.

@Service
class AnotherService {
    @Autowired
    private MailService mailSvc;
    ...
typekcz
  • 113
  • 2
  • 6
0

Your class should have the @Service annotation or Configuration :

@Service
public class MailService {

    @Autowired
    private Environment env;

    ...
}

Read this for more details on why you should avoid static.

Harry Coder
  • 2,429
  • 2
  • 28
  • 32