CURL variables and problems parsing JSON

Question

My script is creating pull requests using the github API:

./my-script.sh my-repo my-branch

#!/bin/bash

Repo=$1
Branch=$2

cd $Repo
 
get_data() {
cat <<EOF
    {
        "title": "PR title",
        "head": $Branch,
        "base": "development",
        "body": "PR description"
    }
EOF
}

echo $(get_data) # <----------------- I can see my value of the variable $Branch here

curl -X POST \
    -H "Accept: application/vnd.github.v3+json" \
    -d "$(get_data)" \ # <----------------- But here I'm facing "Problems parsing JSON"
    -u my_user:my_token \
    https://api.github.com/repos/my_user/$Repo/pulls

open https://github.com/my_user/$Repo/pulls

How can I set my variable into the curl correctly?

@Dan_Maff Feel free to add your answer. I hope my script will be useful for someone — Dmitry Grinko, Dec 16 '21 at 04:33
Did the quotation marks in the data definition work @dmitry-grinko? I would have expected it to require apostrophes there. — Dan_Maff, Dec 16 '21 at 04:38
I didn't try apostrophes. It worked when I wrap the variable in double quotes — Dmitry Grinko, Dec 16 '21 at 04:43
Tangentially, that's a [useless use of `echo`](https://www.iki.fi/era/unix/award.html#echo) — tripleee, Dec 16 '21 at 07:52

score 2 · Accepted Answer · edited Dec 16 '21 at 04:58

2

$Branch needs to be quoted as well:

get_data() {
  cat <<EOF
    {
        "title": "PR title",
        "head": "$Branch",
        "base": "development",
        "body": "PR description"
    }
  EOF
}

edited Dec 16 '21 at 04:58

Dmitry Grinko

13,806
14
62
86

answered Dec 16 '21 at 04:57

Dan_Maff

311
2
7

CURL variables and problems parsing JSON

1 Answers1