Rails is saving empty records

Question

my routes

TerritoryManagement::Application.routes.draw do

  get "new" => "territories#new", :as => "new"

  root :to => "territories#new"
  resources :territories
  resources :users
end

my model

 class Territory < ActiveRecord::Base
   validates :name, :presence => true, :uniqueness => true
   attr_accessor :name
 end

my controller

class TerritoriesController < ApplicationController
  def index
    @territories = Territory.all
  end

  def show
    @territory = Territory.find(params[:id])
  end

  def new
    @territory = Territory.new
  end

  def create
    @territory = Territory.new(params[:territory])
    if @territory.save
      redirect_to root_url, :notice => "Product successfully created!"
    else
      render "new"
    end
  end
end

my view

<%= form_for(@territory) do |f| %>
  <div class="field">
    <%= f.label :name %><br />
    <%= f.text_field :name %>
   </div>
  <div class="actions">
    <%= f.submit %>
  </div>
<% end %>`

my database for some reason the app is generating empty records...

sqlite> select * from territories;
1||2011-08-21 09:44:43.611946|2011-08-21 09:44:43.611946

Any ideas what's going wrong?

I can't see anything immediately that shows what's going wrong. When are these records being generated? When you hit the submit button? — Ryan Bigg, Aug 21 '11 at 10:48

lucapette · Answer 1 · 2011-08-21T11:09:58.730

3

You're confusing attr_accessor with attr_accessible.

EDIT:

attr_accessor is a method that creates getter and setter for the given input symbols. Using it in an ActiveRecord models surely is not a good idea if you're rewriting database properties. I can't say off the top of my head what could happen but ActiveRecord surely misbehaves with it. Your name property is a field of your territories table I think and with rails 3 you have to declare which fields you want to be accessibile with mass-assignment. See docs : http://api.rubyonrails.org/classes/ActiveModel/MassAssignmentSecurity/ClassMethods.html#method-i-attr_accessible

I hope this edit helps ;)

edited Aug 21 '11 at 11:09

answered Aug 21 '11 at 10:48

lucapette

20,564
6
65
59

1

Oh durr! That *always* gets me. Nice catch! – Ryan Bigg Aug 23 '11 at 05:05
@Ryan Bigg It's sooo nice to see you here :D – lucapette Aug 23 '11 at 17:08

score 1 · Answer 2 · answered Aug 21 '11 at 10:52

1

I'm not sure but try to remove the attr_accessor, probably you don't need that.

answered Aug 21 '11 at 10:52

Kleber S.

8,110
6
43
69

Spot on, but why is this attr_accessor here a problem? When do I need it? – Thomas Aug 21 '11 at 10:55
Maybe this post can explain it better. [http://stackoverflow.com/questions/2793098/usage-of-attr-accessor-in-rails] – Kleber S. Aug 21 '11 at 11:47

Rails is saving empty records

2 Answers2