How do i correctly rewrite this function using list comprehension?

Asked Mar 18 '22 at 11:15

Active Mar 18 '22 at 11:15

Viewed 33 times

Given the function

def line2fields(line):
fields = []
i = 1
while i < len(line):
    fields.append(line[i:i+23])
    i += 24
return fields

Rewritten in list comprehension:

def line2fields(line):
fields = []
i = 1
while i < len(line):
    yield i 
i += 24

I am still learning python and want to know if i got this list comprehension right?

asked Mar 18 '22 at 11:15

Godwiin

You haven’t used list comprehension in either example. Check here to see the syntax https://www.w3schools.com/python/python_lists_comprehension.asp – Mar 18 '22 at 11:16
2

`return [line[i:i+23] for i in range(1, len(line), 24)]`…? – deceze Mar 18 '22 at 11:19
@Joe thank you..seeing they used `for` loop, does the same apply to `while` loop as in thre example? – Godwiin Mar 18 '22 at 11:58
@GodwiinLeke A while loop is not possible inside of list comprehension. – Mar 18 '22 at 12:00
@deceze thank you, sorry but where does this go? 1st code block or 2nd code block – Godwiin Mar 18 '22 at 12:05
Either block can be completely replaced by this. – deceze Mar 18 '22 at 12:27
@deceze Oh alright so how's this: `def line2fields(line): return [line[i:i+23] for i in range(1, len(line), 24)]` – Godwiin Mar 18 '22 at 12:39
Yup, that's it. – deceze Mar 18 '22 at 12:44

0 Answers0