(Is same case) loop return not working properly

Question

https://codewars.com/kata/5dd462a573ee6d0014ce715b

Write a function that will check if two given characters are the same case.

If either of the characters is not a letter, return -1

If both characters are the same case, return 1

If both characters are letters, but not the same case, return 0

Examples

'a' and 'g' returns 1
'A' and 'C' returns 1
'b' and 'G' returns 0
'B' and 'g' returns 0
'0' and '?' returns -1

char1 = 'G'
char2 = 'a'

def is_same_case(char1,char2):
    if char1.isupper() and char2.isupper or char1.islower() and char2.islower:
        return 1
    elif char1.isupper() and char2.islower or char1.islower() and char2.isupper:
        return 0
    else:
        return -1

print(is_same_case(char1,char2))
print(char1.isupper())
print(char2.isupper())

It returns 1 instead of 0.

what does `if char2.isupper` return? What is that trying to evaluate? — SuperStew, Jun 09 '22 at 13:51
You're missing `()` on the `char2.isupper` and `char2.islower` function calls. — John Kugelman, Jun 09 '22 at 13:51
For what its worth, the case comparison can be simplified to `a.isupper() == b.isupper()` — Sayse, Jun 09 '22 at 13:55
@Sayse Generally yes, but that won't cover the `?` → `-1` case… — deceze, Jun 09 '22 at 13:58
Sometimes you call the method `isupper()` sometimes you don't `isupper`. Always call it. — tdelaney, Jun 09 '22 at 13:59

score 2 · Accepted Answer · answered Jun 09 '22 at 14:00

You can utilize the isalpha() method to test cases that aren't letters, and then perform a comparison of the isupper() method, and convert the boolean to an integer

def is_same_case(char1, char2):
    if not (char1.isalpha() and char2.isalpha()):
        return -1
    return int(char1.isupper() == char2.isupper())

(Is same case) loop return not working properly

1 Answers1