0

previous issue was resolved thanks to you can anyone also help me with the validation like if a person clicks check with empty field it prints a message in entry2 like "Field cannot be empty" etc

resolved so I've updated the new code and its working fine except the point where attempts == 0 is mentioned when I reach to 0 attempts it starts giving attempts in negative like -1 -2 etc. basically want it to stop at zero and either print a warning or simply stop the program when attempts reaches 0 . I am attaching the entire code for further reference .

from tkinter import *
from tkinter.messagebox import *
import random

root = Tk()
root.title('Number Guessing Game E-project')
root.geometry('500x500')

label1 = Label(root, text= "WELCOME TO NUMBER GUESSING GAME",fg='Maroon',font= ('bold',17))
label2 = Label(root, text= "Enter your guess between 0-999:",font=('Italics',15), fg='Maroon')

label1.grid(row=1 , column=0  ,ipadx=20,pady=10)
label2.grid(row=4 , column=0 ,ipadx=10,pady=10)

player1 = StringVar(root,value="Generate A Random Number First")

entry1 = Entry(root,textvariable=player1,width=30,bd=4)
entry2 = Entry(root,width=30,bd=4)
entry1.grid(row =12 , column= 0 ,ipadx=10,pady=10)
entry2.grid(row =13, column= 0 ,ipadx=10,pady=10)

attempts = 10

chances = StringVar()
chances.set("10 Attempts Remaining")
label4 = Label(root,textvariable=chances,font='Italics')
label4.grid(row=7,column=0 ,ipadx=10,pady=10)

def clear_the_screen():
    entry1.delete(0,END)

def random_num_generate():
    global random_number
    random_number = random.randint(0,999)
    clear_the_screen()

def player_input():
    try:
        user_guess = int(entry1.get())
        winning_logic(random_number,user_guess)


    except ValueError:
        entry2.insert(0,"Enter integers only!")
        clear_the_screen()

def winning_logic(random_no,player_guess):
    global attempts
    global chances
    attempts -= 1

    if attempts == 0:
        chances.set("Oops! You are out of attempts :(")
        clear_the_screen()

    elif player_guess == random_no:
        result1 = 'Bravo! Success!'
        entry2.delete(0, END)
        entry2.insert(0,result1)
        chances.set(f'You Win!')
        win = (f'Congrats! You have guessed the correct number !')
        showinfo(f'Number Guessing Game', win)
        response = askquestion('Number Guessing Game', 'Did you like the game?')
        if response == 'yes':
            showinfo('Number Guessing Game', "That's Great!!")
        else:
            showinfo('Number Guessing Game',"So Sad!")
        root.destroy()

    elif player_guess < random_no and player_guess < 1000:
        result2 = 'Guess Higher!'
        entry2.delete(0,END)
        entry2.insert(0, result2)
        chances.set(f'Wrong! {attempts} attempts remaining')
        clear_the_screen()

    elif player_guess > random_no and player_guess < 1000:
        result3 = 'Guess Lower!'
        entry2.delete(0,END)
        entry2.insert(0, result3)
        chances.set(f'Wrong! {attempts} attempts remaining')
        clear_the_screen()

    elif player_guess > 999:
        result3 = 'Invalid Number!'
        entry2.delete(0, END)
        entry2.insert(0, result3)
        chances.set(f'Invalid Number! {attempts} attempts remaining')
        clear_the_screen()

button1 = Button(root, text='Generate Random No',fg='white',bg='brown',command=random_num_generate)
button1.grid(row=9, column=0,ipadx=20,pady=8)

button2 = Button(root, text='Clear',fg='white',bg='brown',command=clear_the_screen)
button2.grid(row=18, column=0,ipadx=73,pady=10)

button3 = Button(root, text='Check',fg='white',bg='brown',command=player_input)
button3.grid(row=20, column=0,ipadx=70,pady=8)

root.mainloop()
Dua Tariq
  • 1
  • 1
  • You should check whether `attempts` is zero before decreasing it. – acw1668 Jun 28 '22 at 14:45
  • yes it is but afterwards it goes like -1 -2 and so on – Dua Tariq Jun 28 '22 at 15:17
  • I mean you should check whether `attempts` is zero to determine whether to executing `attempts -= 1` or not. – acw1668 Jun 28 '22 at 15:23
  • Can be found https://stackoverflow.com/questions/23842115/how-to-tell-user-how-many-attempts-left-in-python – toyota Supra Jun 28 '22 at 17:15
  • you should rather use `<= 0` instead of `== 0`. – furas Jun 28 '22 at 22:12
  • program could make more sense if you would disable button `Check` at start, and activate it after generating number, and disable it again when `attempts == 0` - this way user can't click it and it can't create negative `attempts` – furas Jun 28 '22 at 22:19
  • when you generate random number then you should also set `attempts = 10` - this way user could restart game. – furas Jun 28 '22 at 22:22

1 Answers1

0

You could check attempts <= 0 instead of attempts == 0.

But I think good idea is to disable button Check so user can't click it and function can't calculate use attempts with value -1

    if attempts <= 0:
        chances.set("Oops! You are out of attempts :(")

        button2['state'] = 'disabled'
        button3['state'] = 'disabled'

        clear_the_screen()
furas
  • 134,197
  • 12
  • 106
  • 148