SKStoreProductViewController crashes for unrecognized selector named sceneDisconnected: in iOS 15.6 beta5

Question

In iOS 15.6 beta5 and iOS 16.0 beta:

When an UISceneDidDisconnectNotification was posted, any active SKStoreProductViewController instance would crash for the unrecognized selector named sceneDisconnected.

-[SKStoreProductViewController sceneDisconnected:]: unrecognized selector sent to instance 0x115161a00

This crash only happened in the latest iOS15.6 and iOS16 beta version. Yet I can't find the selector name in any official documents……

Any solutions? Or Is there anything I haven't done right?

Answer 1

Looks like this was fixed in the iOS 15.6 release candidate that was realeased today.

Sept 14 2022 Update: Apple re-introduced this crash in the official 15.7 release. It only seems to happen when the app is force quit so it should not affect users. I've filed a ticket to Apple on feedbackassistant.apple.com and would encourage others to do the same.

Answer 2

Not a solution, but a clear indication that this is Apple's bug to fix. Starting with a clean sample project, all you need to do is present a SKStoreProductViewController and then force quit your application:

import StoreKit
import UIKit

class ViewController: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()

        let storeKitViewController = SKStoreProductViewController()
        storeKitViewController.loadProduct(withParameters: [
            SKStoreProductParameterITunesItemIdentifier: NSNumber(integerLiteral: 364709193)
        ])
        present(storeKitViewController, animated: true)

        // Force quit after presentation to trigger crash
        // -[SKStoreProductViewController sceneDisconnected:]: unrecognized selector sent to instance
    }

}

I've filed this with Apple via Feedback Assistant.

Answer 3

The crash has been fixed in iOS16

below is an explanation by Apple Framework Engineer

This crash happens in the public release of iOS/iPadOS 15.7, and seed releases of iOS/iPadOS 16 prior to seed 4 [1]. It does not occur in the public release of iOS 16. The crash primarily happens when the app is in the background and is about to be terminated by the operating system. As a result, these crashes are not expected to be visible to the majority of end users. (One exception is on iPad with an app that supports multiple scenes, and a user manually terminates a scene.) Your analytics will show an increased in crash rate, however your customers should not be affected by this issue. We are actively working to address the crash. [1] In which case you should update to the most recent release.

source: https://developer.apple.com/forums/thread/714464?answerId=729646022#729646022

Answer 4

Able to reproduce a crash with the same stack symbols locally and the code below stops the crash from occurring. The code is creating empty functions to handle the unrecognized selector message and restricting this extension to iOS 15.7:

@available(iOS, introduced: 15.7, obsoleted: 16.0)
@objc extension SKStoreProductViewController {
    func sceneDisconnected(_ arg: AnyObject) {}
    func appWillTerminate() {}
}

Answer 5

Add this code in application(_:didFinishLaunchingWithOptions:) (at least before the app is terminated). It adds the methods at runtime if they don’t exist.

if #available(iOS 15.7, *) {
    if #unavailable(iOS 16.0) {
        class_addMethod(
            SKStoreProductViewController.self,
            Selector(("appWillTerminate")),
            unsafeBitCast({ _, _ in } as @convention(c) (SKStoreProductViewController, Selector) -> Void, to: IMP.self),
            "v@:"
        )
        class_addMethod(
            SKStoreProductViewController.self,
            Selector(("sceneDisconnected:")),
            unsafeBitCast({ _, _, _ in } as @convention(c) (SKStoreProductViewController, Selector, NSNotification) -> Void, to: IMP.self),
            "v@:@"
        )
    }
}

---

It seems they removed appWillTerminate and sceneDisconnected(_:) methods in iOS 15.7, but forgot to remove the code that adds UIApplication.willTerminateNotification and UIScene.didDisconnectNotification observers to the NotificationCenter.

---

Edit: They seem to have re-added appWillTerminate and sceneDisconnected(_:) methods in iOS 15.7.1. So I’ve updated the code to add the methods only in iOS 15.7.

---

Edit: They removed the methods AGAIN in iOS 15.7.2 and the crash recurred. I’ve reverted the code.

Answer 6

This is actually an inaccurate reporting because it doesn't actually cause the crash.

I reproduced the reported scene: click on the app-download advertisement in your app, pop up the in-app App Store download page, and then back to the background, the crash message is generated in this time -- but no crash actually occurred, and nothing changed when I returned to the foreground. Everything works fine. The next time the app starts, the crash information will be reported.

So no need to do anything now, just wait for Apple to fix it.

Answer 7

Since version 15.7.1 has been released, we see a decrease in crashes in Firebase Crashlytics. Also when filtering the crashes on iOS version, version 15.7.1 is not present in the list.

This seems a good indication that Apple has finally resolved this issue in 15.7.1.

Please share your observations from your own crash reports to verify that my assumption is correct.

Answer 8

Objective C version, via a category on NSObject. ✌

@interface NSObject (crashPrevent)
@end

@implementation NSObject (crashPrevent)
-(void) sceneDisconnected:(id) item {
    return;
}
-(void) appWillTerminate {
    return;
}
@end