Replace all spaces to dash in all my "url" object from my article model

Question

I would like to replace all the spaces in my defined url objects from my Article model to "-". However, my code below doesn't seem to work.

def index(request):
    change_urls = Article.objects.all()
    for i in change_urls:
        i.url.replace(" ", "-")
        i.save()

What do you mean it doesn't work? What's is the output you get? — Art, Aug 10 '22 at 13:24
my url still didn't change, it still has spaces and no dashes. — Franz Zapanta, Aug 10 '22 at 13:25
`.replace(..)` creates a *new* string, it does not modify the string. — Willem Van Onsem, Aug 10 '22 at 13:26
Does this answer your question? [python str.replace does not actually modify the string](https://stackoverflow.com/questions/44746300/python-str-replace-does-not-actually-modify-the-string) — Abdul Aziz Barkat, Aug 10 '22 at 13:29
Also see [Django bulk update with string replace](https://stackoverflow.com/questions/21464918/django-bulk-update-with-string-replace) which should show how to do it entirely on the DB side. — Abdul Aziz Barkat, Aug 10 '22 at 13:32

Willem Van Onsem · Answer 1 · 2022-08-10T13:33:44.923

1

.replace(..) creates a new string, it does not modify the string. You can thus work with:

def index(request):
    change_urls = list(Article.objects.all())
    for i in change_urls:
        i.url = i.url.replace(' ', '-')
    Article.objects.bulk_update(change_urls, fields=('url',))
    # …

But if you want to "slugify", please use the slugify(…) function ^[Django-doc].

edited Aug 10 '22 at 13:33

answered Aug 10 '22 at 13:27

Willem Van Onsem

443,496
30
428
555

1

I got this error: QuerySet.bulk_update() missing 1 required positional argument: 'fields' – Franz Zapanta Aug 10 '22 at 13:31

Replace all spaces to dash in all my "url" object from my article model

1 Answers1