If else not read third condition in C

Question

I have a task named ''Discounted Coffee Machine'' with these conditions:

if(p<a){
        printf("\nYour balance is not enough.");
        printf("\nRemaining balance: %d",p);
        }
else if(p>=a && dis!=dis2){
        printf("\nEnjoy your Latte. ");
        printf("\nRemaining balance: %d",p-a);
        }
        
else if(p>=a && dis==dis2){
        printf("\nThe discount has been applied.\nEnjoy your Latte.");
        printf("\nRemaining balance: %f",(float)p-(float)a*0.9);
        }

But, if I enter the correct discount code, it doesn't read the second else if. It only reads the first else if. How can I solve this?

I tried with the second else if like only else, but it's not working. I also tried with ',' and '||'.

Best guess -- your discount codes are strings, so you need `strcmp` to compare them -- using `==`/`!=` will compare the addresses of the arrays used to hold them (so will always be `!=`) — Chris Dodd, Dec 16 '22 at 21:28

chux - Reinstate Monica · Accepted Answer · 2022-12-16T21:54:31.903

0

dis and dis2 are character arrays

 char dis[]="ostim"; 
 char dis2[5];

dis!=dis2 compares the addresses of those 2 different arrays and so dis!=dis2 is always true. Code needs to compare the strings at those addresses. @Chris Dodd
Use strcmp() which returns 0 when the strings are the same.

Replace dis!=dis2 with strcmp(dis, dis2) != 0 or simply

// else if(p>=a && dis!=dis2){
else if(p>=a && strcmp(dis, dis2)) {

Likewise for else if(p>=a && dis==dis2).

edited Dec 16 '22 at 21:54

answered Dec 16 '22 at 21:47

chux - Reinstate Monica

143,097
13
135
256

Also, you don't need p>=a, as if you get past the first 'if', that's guaranteed to be true. – user18533375 Dec 17 '22 at 01:29
@user18533375 When `p, a` are floating point types ( a possibility here) `p < a` is not certainly the opposite of `p>=a`. Both may be false when a not-a-number is involved. – chux - Reinstate Monica Dec 17 '22 at 09:20

If else not read third condition in C

1 Answers1