how to toast a message if editText is empty?

Question

I am trying to get a message to appear when a button is clicked to tell the user to fill in the blank field. Currently, if the field is blank, it crashes/force closes the app. the criteria that i need are to have spinners for the Celsius/Fahrenheit options and toast messages if the spinners are both on the same option or if the value is blank

Here is the code

public class MainActivity extends AppCompatActivity {

        private TextView result;
        private EditText enterTemp;
        double result0;

        Spinner ConvertFromUnitTypeSpinner;
        Spinner ConvertToUnitTypeSpinner;


        @Override

    protected void onCreate (Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        //set spinner variables

        ConvertFromUnitTypeSpinner = (Spinner) findViewById(R.id.ConvertFromUnitTypeSpinner);
        ConvertToUnitTypeSpinner =  (Spinner) findViewById(R.id.ConvertToUnitTypeSpinner);

        //String for spinner items
        String [] unitTypes =  {"Fahrenheit", "Celsius"};

        //set up adapter for the layout of the spinner
        ArrayAdapter<String> spinnerAdapter = new ArrayAdapter<>(this,      
         android.R.layout.simple_list_item_1, unitTypes);

        //set up adapter to spinner
        ConvertFromUnitTypeSpinner.setAdapter(spinnerAdapter);
        ConvertToUnitTypeSpinner.setAdapter(spinnerAdapter);

        //set up convert button
        Button convert = findViewById(R.id.convert);
        result = findViewById(R.id.result);
        enterTemp = findViewById(R.id.enterTemp);


        convert.setOnClickListener(new View.OnClickListener(){
            @SuppressLint("SetTextI18n")
            @Override
            public void onClick (View v) {
                double temp = Double.parseDouble(enterTemp.getText().toString());

            if(ConvertFromUnitTypeSpinner.getSelectedItem()=="Fahrenheit"&&
             ConvertToUnitTypeSpinner.getSelectedItem().toString()=="Celsius")
                {
                    result0 = (temp - 32 )*5/9;
                    result.setText(String.valueOf(result0));
                }
           if(ConvertFromUnitTypeSpinner.getSelectedItem()=="Celsius"
              &&ConvertToUnitTypeSpinner.getSelectedItem().toString()=="Fahrenheit")
                {
                    result0 = (temp * 9/5) + 32;
                    result.setText(String.valueOf(result0));
                }
            if (ConvertToUnitTypeSpinner.getSelectedItem()
                ==ConvertToUnitTypeSpinner.getSelectedItem()){
                    result.setText("Units are the same!");
                }
                if (enterTemp.getText().toString().length() == 0)
                {
                    Toast.makeText(MainActivity.this, "It's empty", Toast.LENGTH_SHORT).show();
                  }

                }
              });
             }
           }

I tried replacing the code

if (enterTemp.getText().toString().length() == 0) {
            Toast.makeText(MainActivity.this, "It's empty", Toast.LENGTH_SHORT).show();
          }

to this

if(isEmpty(enterTemp.getText().toString())){
            Toast.makeText(MainActivity.this, "It's empty", Toast.LENGTH_SHORT).show();
         }

also no luck

It crashes because `double temp = Double.parseDouble(enterTemp.getText().toString());` fail to parse the value. My recommendation is that 1st, check the input existence at the beginning of the method. 2nd, exit the run (i.e., `return`) when any of the fail condition met. 3rd, check string equality properly (i.e., use `$String.equals($String)` method instead of `==`. REF: https://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java). 4th, surround the `Double.parseDouble()` with `try catch` for the exception thrown. — Android Newbie A, Jan 16 '23 at 01:17

score 1 · Answer 1 · answered Jan 16 '23 at 01:01

1

You should use TextUtils to achieve your desired result. Something like:

import android.text.TextUtils;

if ( TextUtils.isEmpty(enterTemp.getText()) ) {
   // Display the toast
}

answered Jan 16 '23 at 01:01

Daksh

449
5

score 1 · Answer 2 · answered Jan 16 '23 at 09:21

1

Try this->

if (enterTemp.getText().toString().equals("")) {
            Toast.makeText(MainActivity.this, "It's empty", Toast.LENGTH_SHORT).show();
        }

answered Jan 16 '23 at 09:21

Priyanka Rajpoot

11
4

score 1 · Answer 3 · answered Jan 16 '23 at 10:21

First of all you should check EditText is empty or not and in else part do your conversion:

if (enterTemp.getText().toString().isEmpty())
   {
     Toast.makeText(MainActivity.this, "It's empty", Toast.LENGTH_SHORT).show();
} else {
         if(ConvertFromUnitTypeSpinner.getSelectedItem()=="Fahrenheit"&&
                   
         ConvertToUnitTypeSpinner.getSelectedItem().toString()=="Celsius")
            {
                 result0 = (temp - 32 )*5/9;
                 result.setText(String.valueOf(result0));
            }
            if(ConvertFromUnitTypeSpinner.getSelectedItem()=="Celsius"
                  
          &&ConvertToUnitTypeSpinner.getSelectedItem().toString()=="Fahrenheit")
             {
                  result0 = (temp * 9/5) + 32;
                  result.setText(String.valueOf(result0));
             }
              if (ConvertToUnitTypeSpinner.getSelectedItem()
                        ==ConvertToUnitTypeSpinner.getSelectedItem())
               {
                    result.setText("Units are the same!");
                }
     }

Dipak Luhar · Answer 4 · 2023-01-16T05:26:32.420

0

Your code will be:

if(enterTemp.getText().toString().trim().length() == 0 ){
        Toast.makeText(MainActivity.this, "It's empty", Toast.LENGTH_SHORT).show();
     }

edited Jan 16 '23 at 05:26

answered Jan 16 '23 at 05:26

Dipak Luhar

36
5

how to toast a message if editText is empty?

4 Answers4