Create a picturebox_clicked event for each picturebox created

Question

 private Form1 form1 { get; set; }
    readonly HttpClient httpClient = new();
    public static string FolderPath = @".\Storage";
    public static int picNum = 0;
    public static List<string> outofScopeURL = new List<string>();
    
    private async void Detailed_View_Load_1(object sender, EventArgs e)
    {
        DirectoryInfo directory = new(FolderPath);
        FileInfo[] files = directory.GetFiles();
        string[] FileFormats = { ".png", ".jpg", ".jpeg", ".txt" };
        for (int pictureCreator = 0; pictureCreator < files.Length; pictureCreator++)
        {
            FileInfo file = files[pictureCreator];
            if (file.FullName.EndsWith(FileFormats[3])) 
            {
                string url = File.ReadAllText(file.FullName);
                if (url != null)
                {
                    try
                    {
                        Image gif = Image.FromStream(await httpClient.GetStreamAsync(url));
                        PictureBox picture = new PictureBox
                        {
                            Name = url,
                            Size = new(38, 38),
                            Image = gif,
                            Location = new((gif.Width * pictureCreator), 0),
                            SizeMode = PictureBoxSizeMode.Zoom
                        };
                        this.Controls.Add(picture);
                        MessageBox.Show(picture.Name);
                        outofScopeURL.Add(url);
                        picture.Click += Picture_Click;
                    }
                    catch (Exception ex)
                    {
                        MessageBox.Show(ex.Message);
                    }
                }
                picNum++;
            }
        }
    }

What I'm trying to achieve: I'm trying to look in a specific directory for text files, then I want to read the files and extract the URL present in them. After I got all of the URLs of all the text files present in my folder, I added them into a list so I could use them with their respective picturebox

For example, when URL1 has picture1 and URL2 has picture2, I want to set the text of the clipboard to URL1 when picturebox1 that has picture1 applied to it is clicked.

What I have tried: I have tried making a new picturebox_Clicked event in the pictureCreator for loop but the problem is that the event is always applied to the last picturebox created.

Any help is much appreciated.

`sender` of the event is the clicked `PictureBox`, you can just put something it it's tag while creating the control, and read it later. Or you can just assign some names to the controls, and use a `Dictionary` to store additional data. The key of the dictionary is pictureBoxName, and the value, could be as simple as url, or could be a complex object with any relevant information. — Reza Aghaei, Jan 27 '23 at 12:49
And by the way, PictureBox can load image, if you assign [ImageLocation](https://learn.microsoft.com/en-us/dotnet/api/system.windows.forms.picturebox.imagelocation?WT.mc_id=DT-MVP-5003235&view=netframework-4.8) or use it's [LoadAsync](https://learn.microsoft.com/en-us/dotnet/api/system.windows.forms.picturebox.loadasync?WT.mc_id=DT-MVP-5003235&view=netframework-4.8) method. Look at this post: [Asynchronously Load an Image from a Url to a PictureBox](https://stackoverflow.com/a/37764953/3110834). So no web client is required, unless you have other requirements like authentication, etc. — Reza Aghaei, Jan 27 '23 at 12:51
An one more improvement: Instead of arranging controls yourself, just use a TableLayoutPanel or a FLowLayoutPanel. — Reza Aghaei, Jan 27 '23 at 12:53

IVSoftware · Accepted Answer · 2023-01-27T14:29:27.637

Your question is about creating a picturebox_clicked event for each picturebox created.

The code you posted seems to be doing that but as mentioned in the comments, casting the sender argument would be the key to making event useful. Consider a click handler implemented similar to this:

private void onAnyPictureBoxClick(object? sender, EventArgs e)
{
    if(sender is PictureBox pictureBox)
    {
        var builder = new List<string>();
        builder.Add($"Name: {pictureBox.Name}");
        builder.Add($"Tag: {pictureBox.Tag}");
        builder.Add($"Image Location: {pictureBox.ImageLocation}");
        MessageBox.Show(string.Join(Environment.NewLine, builder));
    }
}

Now give it a test (simulating the part where the URLs are already collected from the local store).

public partial class MainForm : Form
{
    public MainForm() =>InitializeComponent();
    protected override void OnLoad(EventArgs e)
    {
        base.OnLoad(e);
        int id = 0;
        // Here we have "already read" the URLs from the local store.
        foreach (var url in new string[] 
        {
            "https://i.stack.imgur.com/eSiWr.png",
            "https://i.stack.imgur.com/o5dmA.png",
            "https://i.stack.imgur.com/aqAuN.png",
        })
        {
            var dynamicPB = new PictureBox
            {
                Width = flowLayoutPanel.Width - SystemInformation.VerticalScrollBarWidth,
                Height = 200,
                SizeMode = PictureBoxSizeMode.Zoom,
                BackColor = Color.Azure,
                // In this case, the url is already stored here...
                ImageLocation = url,
                // ...but here are a couple of other ID options.
                Name = $"pictureBox{++id}",
                Tag = $"Tag Identifier {id}",
                Padding = new Padding(10),
            };
            dynamicPB.Click += onAnyPictureBoxClick;
            flowLayoutPanel.Controls.Add(dynamicPB);
        }
    }
    .
    .
    .
}

Create a picturebox_clicked event for each picturebox created

1 Answers1