File upload MVC

Question

With the following markup in my view:

<form action="Categories/Upload" enctype="multipart/form-data" method="post">
    <input type="file" name="Image">
    <input type="submit" value"Save">
</form>

And in my controller:

public ActionResult Upload(FormCollection form)
{
    var file = form["Image"];
}

The value of file is null. If I try it in a different view using a different controller Controller and it works with the same code.

I have VS2008 on Vista, MVC 1.0.

Why?

Malcolm

Well the 2 answers given do not and i put money on that no one solves it on SO. — Malcolm, Apr 19 '09 at 11:50

Daniel A. White · Answer 1 · 2011-06-23T17:12:18.293

34

Use HttpPostedFileBase as a parameter on your action. Also, add the AcceptVerb attribute is set to POST.

[AcceptVerbs(HttpVerbs.Post)]
public ActionResult Upload(HttpPostedFileBase image)
{
    if ( image != null ) {
        // do something
    }
    return View();
}

This code is quite in the spirit/design of ASP.NET MVC.

edited Jun 23 '11 at 17:12

answered Apr 19 '09 at 12:03

Daniel A. White

187,200
47
362
445

2

I just spent a couple hours going in circles because my file input tag had an "ID=" attribute, but not a "NAME=" - make sure you include "name=..." or the file will post to the actionresult, but will be null. Hope this helps someone. – Losbear Sep 20 '12 at 02:52

Brett Rigby · Answer 2 · 2012-09-26T09:26:13.953

7

Not to be picky here or anything, but here's how the code ought to look, as Daniel is missing a few minor details in the code he's supplied...

[AcceptVerbs(HttpVerbs.Post)]
public ActionResult UploadPlotImage(HttpPostedFileBase image)
{    
    if ( image != null ) 
    {        
        // do something    
    }

    return View();
}

edited Sep 26 '12 at 09:26

answered Jun 20 '09 at 20:17

Brett Rigby

6,101
10
46
76

1

My guess is Daniel was missing something but saw Brett's post and modified his answer. – Andrew Steitz Jan 03 '12 at 19:11
1

Grammar police! "UploadPlotImadge" >>> "UploadPlotImage" lol =) – Losbear Sep 19 '12 at 21:28

score 6 · Answer 3 · answered Apr 19 '09 at 11:22

6

Try this code:

    public ActionResult Upload()
    {
        foreach (string file in Request.Files)
        {
            var hpf = this.Request.Files[file];
            if (hpf.ContentLength == 0)
            {
                continue;
            }

            string savedFileName = Path.Combine(
                AppDomain.CurrentDomain.BaseDirectory, "PutYourUploadDirectoryHere");
                savedFileName = Path.Combine(savedFileName, Path.GetFileName(hpf.FileName));

            hpf.SaveAs(savedFileName);
        }

    ...
    }

answered Apr 19 '09 at 11:22

Pedro Santos

974
2
14
23

You don't need Request.Files. See this answer: http://stackoverflow.com/questions/765211/file-upload-mvc/765308#765308 – bzlm Jun 23 '09 at 19:30
You need Request.Files if you intend to handle multiple file uploads. – Mark Good Mar 31 '13 at 11:47
1

You also need Request.Files if you posting other form fields. Good solution Pedro. – Tim Jun 28 '13 at 16:22

score 2 · Answer 4 · edited Dec 06 '11 at 06:05

2

Even I was facing a problem , The value was null in image at

public ActionResult UploadPlotImadge(HttpPostedFileBase image)

Earlier I didn't add [AcceptVerbs(HttpVerbs.Post)] which I added. Even after adding it, it didn't work because the second part I was missing, enctype="multipart/form-data", needed to be in the form tag ..

Now it works for me ....

edited Dec 06 '11 at 06:05

Jonathan Spooner

7,682
2
34
41

answered Dec 06 '11 at 05:39

Shrilata Ellaboina

103
1
3
12

enctype="multipart/form-data" was critical for me as well, why doesn't everyone need this? – Slider345 Aug 06 '13 at 16:27

Ram Khumana · Answer 5 · 2011-12-06T06:20:21.880

try this class and below action and fix folder path in AppSetting.

config:

   <appSettings>
            <add key="UploadFolerPath" value="..Your folder path" />
   </appSettings>

view:-

<form action="Account/AddImage" id="form_AddImage" method="post"   enctype="multipart/form-data">

            <input type="file" id="Img" name="Img" class="required" />

            <input type="submit" value="Upload" id="btnSubmit" />

</form>

Class:-

public class FileUpload
{
    public string SaveFileName
    {
        get;
        set;
    }


    public bool SaveFile(HttpPostedFileBase file, string FullPath)
    {
        string FileName = Guid.NewGuid().ToString();

        FileName = FileName + System.IO.Path.GetExtension(file.FileName);

        SaveFileName = FileName;

        file.SaveAs(FullPath + "/" + FileName);
        return true;
    }
}

//Post Action

    [HttpPost]
    public ActionResult AddImage(FormCollection Form)
    {

        FileUpload fileupload = new FileUpload();
         var image="";

        HttpPostedFileBase file = Request.Files["Img"];

        if (file.FileName != null && file.FileName != "")
        {

            if (upload.ContentLength > 0)
            {

                  fileupload.SaveFile(Request.Files["Img"],    Server.MapPath(AppSetting.ReadAppSetting("UploadFolerPath")));

                image = fileupload.SaveFileName;

                // write here your Add/Save function

                return Content(image);


            }
        }
        else
        {
                   //return....;
        }

    }

File upload MVC

5 Answers5

Linked