headers already sent through flush function?

Question

I got an interesting error which says that headers were already sent through ob_end_flush(); when I run the below code. This is the exact error I am getting

Warning: Cannot modify header information - headers already sent by (output started at /export/home/ua/games/gamescripts/login_backend2.php:47) in /export/home/ua/games/gamescripts/login_backend2.php on line 57 should have redirected by now

line 47 is ob_end_flush();

Edit: Sorry I was a bit careless while pasting my code. I have now arranged it in a right format.

<?php

include_once('Services_JSON.php');
include 'connect.php';
include_once('functions.php');
error_reporting(E_ALL | E_WARNING | E_NOTICE);
ini_set('display_errors', TRUE);


$json = new Services_JSON();  
$username=  $_POST["username"];  
$password = $_POST["password"];  

$check=0;  
$query="SELECT * FROM `game_users` WHERE `username` LIKE  '$username'";  
$result = mysql_query($query)  
or  
 die("<br>Query Error: ".mysql_error());  

while($row = mysql_fetch_row($result))  
{  

    $user = $row[2];  
    $pass = $row[3];  
    $name = $row[1];  

        if($username == $user )  
        {  

            if($password == $pass)  
            {    
                              $Day = 86400 + time(); // 1 Day    
                              $name= "name";  
                              $user= "user";  
                              $pass= "password";  
                              ob_start();  
                              //creating cookie for one day  
                              setcookie("username", $user, $Day);  
                              $cookiename = $name.$user;                    
                              setcookie("games", $cookiename, $Day);    
                              createSession($user,$cookiename);  
                              ob_end_flush();  
                              $data = array($user, $pass, $name);           
                              $check=1;  
                              flush();  
                              header("Location:                  http://www.uark.edu/ua/games/gamescripts/Game/Game.html");  
                              die('should have redirected by now');  


            }

        }

}
if($check==0)
{
    $data = array("failed", "failed", "failed","failed");
    echo $json->encode($data);
}
 ?>

score 5 · Accepted Answer · answered Oct 12 '11 at 18:27

flush() sends the headers already queued up (the cookies in this case). Remove the flush() call. This code will throw an error about not being able to output the 2nd header:

<?php
    header('a: 1');
    flush();
    header('b: 2');
?>

You can also remove the output buffering - it does nothing useful here. This code works fine, however:

<?php
    ob_start();
    header('a: 1');
    ob_end_flush();
    header('b: 2');
?>

Only flush() actually sends headers.

score 4 · Answer 2 · answered Oct 12 '11 at 03:24

4

Make sure you do not have any spaces or newline characters before the opening <?php tag.

answered Oct 12 '11 at 03:24

Jimtronic

1,179
1
9
22

1

Yeah.. looks like he has some spaces at the beginning of his very artistic formatting. – mpen Oct 12 '11 at 03:29
1

In addition, make sure none of the included php files have any spaces, newlines, or output of any kind. – Jimtronic Oct 12 '11 at 03:34
@Jimtronic I checked my original code and also the included files.. there are no spaces, newlines or output – Oct 12 '11 at 03:57
You can't use `header("Location` after having set the cookies. – Jimtronic Oct 12 '11 at 04:11
But i used header with cookies previously and it worked for me. – Oct 12 '11 at 06:20
Hmmm, I've run into problems with php errors or warnings being output prior to using the `header()` method. – Jimtronic Oct 12 '11 at 15:02

headers already sent through flush function?

2 Answers2

Linked