MergeAdapter - removing a child adapter + unregisterDataSetObserver()?

Question

I'd like to remove an adapter from a MergeAdapter, as per this question:

Do we need to clean up the observer registered with the child adapter in addAdapter()? For example:

public void addAdapter(ListAdapter adapter) {
    pieces.add(adapter);
    adapter.registerDataSetObserver(new CascadeDataSetObserver()); /// *** ///
}

public void removeAdapter(int position) {
    ListAdapter adapter = pieces.remove(position);
    adapter.unregisterDataSetObserver(????);  //// ??? ////
}

Do we need to unregister the datasetobserver here?

What does the title of your questions have to do with your actual question? — Kurtis Nusbaum, Nov 10 '11 at 19:22

score 1 · Answer 1 · answered Nov 10 '11 at 23:37

You could if you wanted. However, bear in mind that all registerDataSetObserver() is doing, in effect, is setting up a reference from the added ListAdapter to the MergeAdapter, not the other way around. Hence, so long as you will be discarding your removed ListAdapter, the registered observer should also get garbage-collected.

MergeAdapter - removing a child adapter + unregisterDataSetObserver()?

1 Answers1