insert not working in jsp with msaccess

Question

i am new in jsp and i used this code to insert data into msaccess table i got problem that when i click submit button after filing all required field the page should redirect to quiz.jsp. but it is not happening and noting inserted to the db too.

<%@page language="java" import="java.sql.*" %>

<%
   if(request.getParameter("submit")!=null)
 {
Connection conn=null;
Statement stmt=null;
try
{
    Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
    conn=DriverManager.getConnection("jdbc:odbc:biplob");
try{
Statement st = con.createStatement();
String quest = request.getParameter("quest").toString();
String QA = request.getParameter("QA").toString();
String QB = request.getParameter("QB").toString();
String QC = request.getParameter("QC").toString();
String QD = request.getParameter("QD").toString();
String correctAns = request.getParameter("correctAns").toString();
       out.println("quest : " + quest);

   String qry = "insert into quiz(quest,QA,QB,QC,QD,correctAns)values('"+quest+"','"+QA+"','"+QB+"','"+QC+"','"+QD+"','"+correctAns+"')";

     out.println("qry : " + qry);

int val = st.executeUpdate(qry);

    if(val>0)
    {
      response.sendRedirect("quiz.jsp");
    }
con.close();
   }

   catch(SQLException ex){
System.out.println("SQL satatment not found");
   }
   }
   catch(Exception e){
e.printStackTrace();
   }
   }
   %>

pls help me wih this .. where is wrong in this code .

Have you tried to replace single quotes with double quotes in the SQL string? — Andrea Colleoni, Nov 14 '11 at 10:57
Are you sure your code get into the If statement ("submit")!=null)? — Massimiliano Peluso, Nov 14 '11 at 10:58

score 1 · Answer 1 · edited Nov 17 '12 at 14:26

1

You have kept one extra closing brace. I think it will work if you remove it.

edited Nov 17 '12 at 14:26

Echilon

10,064
33
131
217

answered Nov 17 '12 at 14:08

surya

11
1

score 0 · Answer 2 · edited May 23 '17 at 10:34

0

Scriplets are really bad practice in jsp , you should avoid using it . The workflow you mentioned can entirely done without scriplet . Insert data to the db from servlet instead.

Do it in that way and if you would face any problems ask it here at SO. See How to avoid Java Code in JSP-Files?.

edited May 23 '17 at 10:34

Community

1
1

answered Nov 14 '11 at 11:05

Sandeep Pathak

10,567
8
45
57

score 0 · Answer 3 · answered Nov 14 '11 at 14:59

Replace

    } catch(SQLException ex) {
        System.out.println("SQL satatment not found");
    }
} catch(Exception e) {
    e.printStackTrace();
}

by

    } catch(SQLException ex) {
        throw new ServletException(ex);
    }
} catch(Exception e) {
    throw new ServletException(e);
}

To get a detailed error report complete with the root cause exception, its message and the full stacktrace. It contains the answer.

insert not working in jsp with msaccess

3 Answers3