Why my project doesn't link if there are Q_OBJECT macros in .cpp files?

Question

This code compiles, links and works as intended:

#include <QApplication>
#include <QListView>
#include "File_List_Model.h"

int main(int c,char**v)
{
    QApplication app(c,v);
    QStringList list;

    list << "a" << "b" << "c";

    File_List_Model* model = new File_List_Model;
    model->set_entries(list);

    QListView* view = new QListView;
    view->setModel(model);
    view->show();

    return app.exec();
}

But when I put the class definition in .cpp file instead of header files, I get linker errors stating that vtable was not properly defined.

#include <QApplication>
#include <QListView>
//#include "File_List_Model.h"
#include "File_List_Proxy.h"
#include <QAbstractItemModel>
#include <QStringList>

class File_List_Model : public QAbstractItemModel
{
    Q_OBJECT
private:
    QStringList data_;
public:
    File_List_Model(QObject *parent = 0) :
        QAbstractItemModel(parent)
    {
    }

    int columnCount(const QModelIndex& parent) const
    {
        return 1;
    }

    QVariant data(const QModelIndex & index, int role) const
    {
        switch(role)
        {
            case Qt::DisplayRole:
            return data_[index.row()];
        default:
            return QVariant();
        }
    }

     QModelIndex index(int row, int column, const QModelIndex & parent) const
    {
        return createIndex(row,column);
    }

    QModelIndex parent(const QModelIndex & index) const
    {
        return QModelIndex();
    }

     bool set_entries(const QStringList& entries)
     {
         if (entries.size())
         {
         beginInsertRows(createIndex(0,0),0,entries.size());
         data_ = entries;
         endInsertRows();
         emit dataChanged(createIndex(0,0),createIndex(0,entries.size()));
         return true;
         }
         else
         {
             return false;
         }
     }

     int rowCount(const QModelIndex & parent) const
     {
         return data_.size();
     }


};

int main(int c,char**v)
{
    QApplication app(c,v);
    QStringList list;

    list << "a" << "b" << "c";

    File_List_Model* model = new File_List_Model;
    model->set_entries(list);

    File_List_Proxy* proxy = new File_List_Proxy;
    proxy->setSourceModel(model);

    QListView* view = new QListView;
    view->setModel(proxy);
    view->show();

    return app.exec();
}

//error:   
debug/moc_File_List_Model.o:moc_File_List_Model.cpp:(.rdata$_ZTV15File_List_Model[vtable for File_List_Model]+0x44): undefined reference to `File_List_Model::columnCount(QModelIndex const&) const'
debug/moc_File_List_Model.o:moc_File_List_Model.cpp:(.rdata$_ZTV15File_List_Model[vtable for File_List_Model]+0x4c): undefined reference to `File_List_Model::data(QModelIndex const&, int) const'

This seems to be exactly the same code. Why does it link when the code is in headers and it doesn't link otherwise?

score 6 · Accepted Answer · edited Jul 14 '16 at 18:18

6

Qt uses moc tool to handle C++ extensions that a required, for example, for signals-slots mechanism. This tool processes all header (!) files in the project and generates new source files that contain meta-object code for those classes that contain Q_OBJECT macro.

When you have your class defined in .cpp file instead of .h file moc fails to process it properly.

Have a look at this article for more information about Qt Meta-Object Compiler.

edited Jul 14 '16 at 18:18

Kuba hasn't forgotten Monica

95,931
16
151
313

answered Nov 29 '11 at 07:22

KL-7

46,000
9
87
74

qmake and cmake Qt support invokes moc on all source files listed in the project that contain the `Q_OBJECT` macro. This happens no matter the extension of the file. In the case of the question, the moc output wasn't passed to the compiler because qmake/cmake can't do that automatically. – Kuba hasn't forgotten Monica Jul 14 '16 at 18:34

score 0 · Answer 2 · edited May 23 '17 at 12:22

The linker is complaining about missing the object code that comes from compiling moc output. That's because although moc has processed the source file, its output was not compiled into an object file.

For header files, the build system assumes that they are meant for inclusion in multiple translation units and won't violate the one definition rule. Thus moc output can include the header file, and get compiled as a stand-alone translation unit.

But, if you have any Q_OBJECT macros within a .cpp file, the moc output cannot be compiled in isolation: it won't have access to the declarations from your .cpp file and thus can't compile! It also can't include your .cpp file, since that would violate the one definition rule: two translation units - moc output and your .cpp file - would define the same stuff.

Instead, you need to append moc's output to the end of the .cpp file. E.g., if you have O_OBJECT in main.cpp, add #include "main.moc" at the end of the file:

// main.cpp
#include <QtCore>

struct Object : QObject {
  Q_OBJECT
};

int main() {
  Object o;
  qDebug() << o.metaObject()->className();
}

#include "main.moc"
// "main.moc" depends on the declaration of Object above!

The above is an SSCCE.

One could argue that perhaps qmake/cmake should set up the build so that moc output is automatically appended to the .cpp file before it's sent to the compiler. So far, that feature is not implemented.

score 0 · Answer 3 · answered Nov 29 '11 at 07:13

0

Because Qt runs moc on header files and don't run it on sources.

answered Nov 29 '11 at 07:13

arrowd

33,231
8
79
110

That is false: qmake and cmake run moc on all source files that contain the `Q_OBJECT` macro. What wasn't done here was to run the compiler on the output of moc. – Kuba hasn't forgotten Monica Jul 14 '16 at 18:23

Why my project doesn't link if there are Q_OBJECT macros in .cpp files?

3 Answers3