Template and vector errors

Question

I dont know what im doing wrong this is my first time seperating .cpp files and using templates and vectors. I keep getting these two errors: error C2143: syntax error : missing ',' before '<' and error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

main.cpp

#include <iostream>
#include <vector>
using namespace std;

template <typename T>
void write_vector(const vector<T>& V);

int main()
{
    int n;
    int value;
    vector<int> V;
    cout << "Enter n: ";
    cin >> n;
    cout << "Enter " << n << " integer values: ";
    while(V.size() < n && cin >> value){
        V.push_back(value);
    }

    write_vector(V);

    return 0;
}

writeVector.cpp

template <typename T>
void write_vector(const vector<T> &V)
{
    for(int i=0; i < V.size(); i++)
        cout << V[i] << " ";
}

do you #include or explicitly instantiate the function? your question lacks details. — Gene Bushuyev, Dec 06 '11 at 20:26
Where do you include writeVector.cpp?- It should be eventually included in main.cpp, since templates can not be compiled separately to object file. On what lines do you receive your errors? — dimba, Dec 06 '11 at 20:27

score 3 · Accepted Answer · edited May 23 '17 at 12:10

3

You need explicit instantiation to do this because the compiler doesn't know what types the template needs to be compiled for when compiling the .cpp. See Explicit instantiation - when is it used?.

edited May 23 '17 at 12:10

Community

1
1

answered Dec 06 '11 at 20:25

Codie CodeMonkey

7,669
2
29
45

So what would my .h and .cpp files look like. – Sean Dec 06 '11 at 20:50

score 3 · Answer 2 · edited May 23 '17 at 12:02

3

Your template function must be defined in advance so that the compiler can use it. Either define it before main() in the single file or #include it in a header file.

In summary, template functions should be defined in header files. See the answer to Why can templates only be implemented in the header file?

edited May 23 '17 at 12:02

Community

1
1

answered Dec 06 '11 at 20:27

koan

3,596
2
25
35

isn't my template defined before main? – Sean Dec 06 '11 at 20:56
The compiler only knows that a template type exists. You need to move the definition to a header file and #include it before main or copy it above main. – koan Dec 06 '11 at 21:07

score 1 · Answer 3 · answered Dec 06 '11 at 20:25

1

As far as I remember you cannot separate the declaration and implementation of a template.

answered Dec 06 '11 at 20:25

Christian Horsdal

4,914
23
24

score 0 · Answer 4 · answered Dec 06 '11 at 20:25

0

You need the includes and using in both files. At that point, you might need the explicit instantiation mentioned in other answers, but those will show up as linker issues.

answered Dec 06 '11 at 20:25

smparkes

13,807
4
36
61

score 0 · Answer 5 · 2011-12-06T20:36:54.930

write_vector needs to be in a header file (writeVector.h) rather than a .cpp file if you want to share it between different modules. For more information about why you need to do this see the C++ FAQ.

I presume that your syntax error is because you have a missing using namespace std; in writeVector.cpp? When you move it to a header file you should not put this using directive there because that will needlessly pollute the global namespace whenever this file is included. Instead you should explicitly qualify all references to vector as std::vector.

score 0 · Answer 6 · answered Dec 06 '11 at 20:42

On the top of you main.cpp add :

#include "Vector.cpp" // since you are learning, this is really strange and should be avoided, but for your example we leave it as is.

In your Vector.cpp

#include <vector>
#include <iostream>

template<class T>
void write_vector(const std::vector<T>& V)
{
    for(int i=0; i < V.size(); i++)
        std::cout << V[i] << " ";
}

Do not use using statements. Bad habit. You don't need explicit instantiation or other stuff. Your compiler can deduct the correct template.

Altough this works, it's bad code. When using template always write everything in the .h file. So change your Vector.cpp to Vector.h. Remove the forward declaration from your main.cpp and #include "Vector.cpp"

Your code will work fine without any other changes.

Finally the C++ way of doing things would be e.g. :

#include <vector>
#include <iostream>
#include <algorithm>

template<class T>
void write_vector(const std::vector<T>& V)
{
    std::copy(V.begin(), V.end(), std::ostream_iterator<T>(std::cout, " ")); // you don't even need this function right?
    //for(int i=0; i < V.size(); i++)
 //       std::cout << V[i] << " ";
}

You can do similar things for the cin.

Template and vector errors

6 Answers6