13

My questions is, suppose we have two classes A and B. I want to have an object of B in class A.

Should I use,

class A
{
public:
    A();
    ~A();
    B* b;
};

or

class A
{
public:
    A();
    ~A();
    B b;
};

As far as I know, in the first scenario, I can initialize the object *b using new operator and for the second scenario, I can initialize b using an initialization list if I don't want to use the default constructor of class B. Which is more convenient to use?

AustinWBryan
  • 3,249
  • 3
  • 24
  • 42
hk84
  • 133
  • 1
  • 4

5 Answers5

11

It depends.

Even if you use the pointer, you can initialize the member in the initialization list, but that's not your biggest concern.

There are advantages and disadvantages to both:

Using a pointer:

Pros:

  • the class will be smaller in memory

  • you only need a forward declaration to the other class - no need to include the other header in your header

  • can use derived objects from B as members

Cons:

  • memory management - this is a pretty big one. Do you want the memory to be managed by the class (override destructor, assignment operator and copy constructor)?

Using an object:

Pros:

  • no need to worry about memory management

Cons:

  • can only use objects of the base class. What if you want to derive from B?

  • more memory for each instance

  • constructor of B will be called on construction of A

  • you need the full definition of B inside the header

I'll edit my answer if I think of more.

Community
  • 1
  • 1
Luchian Grigore
  • 253,575
  • 64
  • 457
  • 625
7

In this scenario, the non-pointer version is more convenient. You don't need to worry about invoking delete at the correct time, and therefore you don't need to worry about destructors, copy constructors and copy assignment operators.

In general, you should avoid dynamically-allocated memory as much as possible.

Oliver Charlesworth
  • 267,707
  • 33
  • 569
  • 680
  • In general, you're right, but there are situations where pointers are needed. – Luchian Grigore Dec 21 '11 at 12:36
  • 1
    Thanks for the answer. How one should decide when to use pointers? – hk84 Dec 21 '11 at 12:48
  • 1
    @user1109792 in general if the pointer is to a base class, but you can assign to it objects of derived classes, you use pointers. Also, if multiple instances can contain the same object, you can use pointers to save memory, but you have to be very careful managing the memory. – Luchian Grigore Dec 21 '11 at 12:52
5

Second one is more convenient , because you don't need to manage memory yourself. No new, no delete.

If you go with the first one, then you probably have to implement Rule of Three also (in C++03):

Or, Rule of Five (in C++11):

The underlying idea behind this rule is the following:

So unless you've strong reason why you need pointer version (such as in case when you need polymorphic behavior), you must go with the second approach (the non-pointer approach).

Community
  • 1
  • 1
Nawaz
  • 353,942
  • 115
  • 666
  • 851
2

Use the second, try to avoid using new as much as possible in C++ unless you are using RAII.

Alok Save
  • 202,538
  • 53
  • 430
  • 533
1

If you want an object of class B in A, then you must use the second. The first doesn't give you an object of type B in A, it gives you an object of type B* in A.

The second is also more convenient for almost all purposes. Only use a pointer when you have to, and even then resource-handling is more convenient with a smart pointer rather than a B*.

Steve Jessop
  • 273,490
  • 39
  • 460
  • 699