expected ';' after expression

Question

I'm trying to port a project from Windows to Mac. I'm having troubles compiling the class CFactory. I'll try to illustrate the problem.

Here's what I have on my Factory.h

namespace BaseSubsystems
{
    template <class T>
    class CFactory
    {
    protected:
        typedef T (*FunctionPointer)();
        typedef std::pair<std::string,FunctionPointer> TStringFunctionPointerPair;
        typedef std::map<std::string,FunctionPointer> TFunctionPointerMap;
        TFunctionPointerMap _table;
    public:
        CFactory () {}
        virtual ~CFactory();
    }; // class CFactory

    template <class T> 
    inline CFactory<T>::~CFactory()
    {
        TFunctionPointerMap::const_iterator it = _table.begin();
        TFunctionPointerMap::const_iterator it2;

        while( it != _table.end() )
        {
            it2 = it;
            it++;
            _table.erase(it2);
        }

    } // ~CFactory
}

When I'm trying to compile, the compiler complains:

Factory.h:95:44: error: expected ';' after expression [1]
         TFunctionPointerMap::const_iterator it = _table.begin();
                                            ^
                                            ;

Why is this happening? That am I missing?

NOTE: This project compiles properly on MSVC.

Thanks.

[Needs more `typename`](http://stackoverflow.com/questions/610245/where-and-why-do-i-have-to-put-the-template-and-typename-keywords). — R. Martinho Fernandes, Feb 06 '12 at 02:57
`typename TFunctionPointerMap::const_iterator` should fix it. See the link I posted for all the gritty details. — R. Martinho Fernandes, Feb 06 '12 at 03:00
Can you check if it makes a difference when you replace TFunctionPointerMap with the structure it is typedeffing (i.e. std::map)? — Shredderroy, Feb 06 '12 at 03:01
It does. Thanks. I'll take a look at the document. Really helpful tip — frarees, Feb 06 '12 at 03:02
Very enlightening response my R. Martinho Fernandes. Thanks! — Shredderroy, Feb 06 '12 at 03:03
Btw now it complains about `_table.erase(it2)`, it says `no matching member function for call to 'erase'`, any tip for that? I'm really a beginner about such advanced details of C++ — frarees, Feb 06 '12 at 03:05

score 4 · Accepted Answer · edited Feb 06 '12 at 04:19

4

You are missing the required typename keyword when referring to a dependent type. Microsoft Visual Studio incorrectly accepts your code without the typename (this is a well known mistake in VS that will never be corrected).

typename TFunctionPointerMap::const_iterator it;

edited Feb 06 '12 at 04:19

Xeo

129,499
52
291
397

answered Feb 06 '12 at 03:26

David Rodríguez - dribeas

204,818
23
294
489

expected ';' after expression

1 Answers1