php - push array into array - key issue

Question

i am trying to push multiple arrays into 1 big array, resulting in a 2 lvl array.

I got this set of arrays for example:

Array
(
    [cod] => ddd
    [denum] => ffffffffffffffff
    [descr] => ggggggg
    [cant] => 3
)
Array
(
    [cod] => fff
    [denum] => dfgdfgdfgdfgdfg
    [descr] => dfgdfgdfgdfgdfg
    [cant] => 33
)

But, after array push, i get this array:

Array
(
    [0] => Array
        (
            [0] => ddd
            [1] => ffffffffffffffff
            [2] => ggggggg
            [3] => 3
        )

    [1] => Array
        (
            [0] => fff
            [1] => dfgdfgdfgdfgdfg
            [2] => dfgdfgdfgdfgdfg
            [3] => 33
        )

)

Basically this is what i want to do, BUT, if you notice after the push, the keys are forgotten, and converted to numeric.

This is what i want it to look like:

Array
(
    [0] => Array
        (
            [cod] => ddd
            [denum] => ffffffffffffffff
            [descr] => ggggggg
            [cant] => 3
        )

    [1] => Array
        (
            [cod] => fff
            [denum] => dfgdfgdfgdfgdfg
            [descr] => dfgdfgdfgdfgdfg
            [cant] => 33
        )

)

sample code im using:

$res_arr_values = array();
while ($row = mysql_fetch_array($result, MYSQL_ASSOC))
   {
       array_push($res_arr_values, array_values($row));
   }

Can someone help me with it ?

No one should be using `mysql_` functions anymore. See [get array of rows with mysqli result](https://stackoverflow.com/q/1501274/2943403) — mickmackusa, Aug 28 '22 at 06:26

score 51 · Accepted Answer · answered Mar 04 '12 at 12:24

Don't use array_values on your $row

$res_arr_values = array();
while ($row = mysql_fetch_array($result, MYSQL_ASSOC))
   {
       array_push($res_arr_values, $row);
   }

Also, the preferred way to add a value to an array is writing $array[] = $value;, not using array_push

$res_arr_values = array();
while ($row = mysql_fetch_array($result, MYSQL_ASSOC))
   {
       $res_arr_values[] = $row;
   }

And a further optimization is not to call mysql_fetch_array($result, MYSQL_ASSOC) but to use mysql_fetch_assoc($result) directly.

$res_arr_values = array();
while ($row = mysql_fetch_assoc($result))
   {
       $res_arr_values[] = $row;
   }

'the preferred way to add a value to an array is writing $array[] = $value; ' This is profound, thanks, reminding one self of that bit helps keep the program simple — pal4life, Apr 30 '15 at 11:16

score 8 · Answer 2 · answered Mar 04 '12 at 12:39

8

I think you have to go for

$arrayname[indexname] = $value;

answered Mar 04 '12 at 12:39

Saiyam Patel

1,161
9
18

Shlomtzion · Answer 3 · 2018-11-27T22:09:18.843

7

All these answers are nice however when thinking about it....
Sometimes the most simple approach without sophistication will do the trick quicker and with no special functions.

We first set the arrays:

$arr1 = Array(
"cod" => ddd,
"denum" => ffffffffffffffff,
"descr" => ggggggg,
"cant" => 3
);
$arr2 = Array
(
"cod" => fff,
"denum" => dfgdfgdfgdfgdfg,
"descr" => dfgdfgdfgdfgdfg,
"cant" => 33
);

Then we add them to the new array :

$newArr[] = $arr1;
$newArr[] = $arr2;

Now lets see our new array with all the keys:

print_r($newArr);

There's no need for sql or special functions to build a new multi-dimensional array.... don't use a tank to get to where you can walk.

edited Nov 27 '18 at 22:09

answered Nov 27 '18 at 21:51

Shlomtzion

674
5
12

1

Thanks for giving a simple answer, for other readers. (Note that this is the same technique as accepted answer shows. It only looked more complicated *there*, because there it was answered within the context of the question. The key line in accepted answer is: `$res_arr_values[] = $row;`, identical to this answer's `$newArr[] = $arr1;`) – ToolmakerSteve Feb 18 '21 at 20:19
Indeed. I agree with every word. :) – Shlomtzion Mar 14 '21 at 21:05

Adrian Gunawan · Answer 4 · 2012-03-04T20:35:44.297

1

Use this..

$res_arr_values = array();
while ($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
    $res_arr_values[] = $row;
}

edited Mar 04 '12 at 20:35

answered Mar 04 '12 at 12:23

Adrian Gunawan

13,979
11
40
41

`array_push` and this syntax is same. – Shiplu Mokaddim Mar 04 '12 at 12:27
`array_push()` **does** preserve keys `array_values()` does not. – Leigh Mar 04 '12 at 12:27
I did not use array_push. I have remove array_values from the answer – Adrian Gunawan Mar 04 '12 at 12:28
the problem is not your example, it's your explanation. it's just wrong. do your research before answering. – Basti Mar 04 '12 at 12:55

score -1 · Answer 5 · answered Jan 23 '17 at 13:06

-1

first convert your array too JSON

while($query->fetch()){
   $col[] = json_encode($row,JSON_UNESCAPED_UNICODE);
}

then vonvert back it to array

foreach($col as &$array){
   $array = json_decode($array,true);
}

good luck

answered Jan 23 '17 at 13:06

milad nazari

339
3
5

What benefit does converting to json add? Answer: none. Sorry, this answer is not helpful to this Q&A. – ToolmakerSteve Feb 18 '21 at 20:22

score -2 · Answer 6 · answered Mar 11 '13 at 18:45

-2

$res_arr_values = array();
while ($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
    $res_arr_values[] = $row;
}


array_push == $res_arr_values[] = $row;

example 

<?php
$stack = array("orange", "banana");
array_push($stack, "apple", "raspberry");
print_r($stack);

Array
(
    [0] => orange
    [1] => banana
    [2] => apple
    [3] => raspberry
)
?>

answered Mar 11 '13 at 18:45

rasvi

13
2

7

Would you consider adding some narrative to explain why this code works, and what makes it an answer to the question? This would be very helpful to the person asking the question, and anyone else who comes along. – Andrew Barber Mar 11 '13 at 18:46
@user1248047 don't wanted to learn array_push function, he/she just to know how prevent to replacing key values – SagarPPanchal Feb 04 '14 at 05:45
There are multiple answers written a year before this one, that show the technique. I don't see that this answer adds any value. If I'm wrong, please add an explanation of what is new about this answer. – ToolmakerSteve Feb 18 '21 at 20:25

php - push array into array - key issue

6 Answers6

Linked