Optimised Retrieval of the Checked RadioButton in Relevent GroupBox

Question

All, I have a GroupBox with multiple controls (Buttons, RadioButtons etc.) and I want to know the most efficent way of establishing which RadioButton in the GroupBox is in the checked state. I currently have

int nCheckedRadioIdx = 0;
foreach (Control ctrl in groupBoxList.Controls)
{
    if (ctrl.GetType() == typeof(RadioButton))
    {
        if (((RadioButton)ctrl).Checked)
        {
            switch (((RadioButton)ctrl).Name)
            { 
                case "radioButtonGoodCodeSumm":
                    nCheckedRadioIdx = 0;
                    break;
                case "radioButtonBadCodeSumm":
                    nCheckedRadioIdx = 1;
                    break;
                case "radioButtonBadByEpiNo":
                    nCheckedRadioIdx = 2;
                    break;
                case "radioButtonValidCodes":
                    nCheckedRadioIdx = 3;
                    break;
                default:
                    break;
            }
            break;
        }
    }
}

I then use an enumerator to establish which button I need. This seems very verbose to me (in fact damn ugly!). I have seen this done in VB with some sort of LINQ query (SO Question) but I have never worked with VB or LINQ and am struggling with the conversion. If there is an even better way that would be great as one of the GroupBoxs contains a significant number of RadioButtons - I would like to use LINQ for this if possible?

The direct translation of that VB.NET code to C# would be something like: `RadioButton rButton = GroupBox1.Controls.OfType.Where(r => r.Checked == true).FirstOrDefault();` — Cody Gray - on strike, Mar 15 '12 at 10:27

Steve · Accepted Answer · 2012-03-15T11:29:38.790

2

Suppose you have, for each radiobutton THE SAME event handler that, when the button is checked set the Tag property of your GroupBox to the Tag of your RadioButton. At design time you set the Tag of the RadioButton to your desidered enum value. When you wish to retrieve your checked button you have only to read the Tag property without going through a loop (elegant or less) to check every control in your GroupBox.

For example:

private void RadioButton_Checked(oject sender, EventArgs e)
{
    RadioButton radio = ((RadioButton)sender);
    if(radio.Checked)
        groupBoxList.Tag = radio.Tag;
}

Of course this will be efficient, but you should be sure to well document this because a change in the enum change will create problems.

edited Mar 15 '12 at 11:29

answered Mar 15 '12 at 10:35

Steve

213,761
22
232
286

+1 Thanks good idea. I would like to use LINQ however. For the fun of it! :] – MoonKnight Mar 15 '12 at 10:38
@Killercam, I like LINQ too, but it seems inefficient in this case. – Steve Mar 15 '12 at 10:45
I concious of adding this event handler for every `RadioButton`. What is the deal here? Thanks for your time... – MoonKnight Mar 15 '12 at 11:24
1

Perhaps I have not spelled my intentions correctly. I think to use one event handler for all the radiobuttons. I mean the same event handler! Updated answer. – Steve Mar 15 '12 at 11:31

score 1 · Answer 2 · edited Oct 27 '12 at 15:13

1

foreach (var control in groupBox3.Controls)
{                
    RadioButton radio = control as RadioButton;

    if (radio != null && radio.Checked)
    {
        var a = radio.Name;   //it gives the name of radio button is checked
    }
}

edited Oct 27 '12 at 15:13

Adi Lester

24,731
12
95
110

answered Oct 27 '12 at 13:56

Kailas

3,173
5
42
52

Optimised Retrieval of the Checked RadioButton in Relevent GroupBox

2 Answers2