47

My bash prompt, which I'll admit to have stolen from a few places and cobbled together, will sometimes add part of previous commands to its length when scrolling the bash history with up/down arrows.

For example, if my previous commands were:

ls
cd /home/caleb
vim .bashrc

When I was at my prompt and scrolled up twice it might look like:

$ vim .bcd /home/caleb

Where the first five characters are left over from last command.

Does anyone have any idea why this is happening, and how it can be stopped?

My prompt is set with this code (way to long to include here): https://gist.github.com/1679352

Andrew Lambert
  • 7,805
Caleb Hearth
  • 597

7 Answers7

60

The color codes need to be wrapped in square brackets. The brackets inform bash that the enclosed text should not be printed

building on @Phreditor's example, this shows that any formatting done after the newline will result in the original issue:

export PS1="\n\n\[\033[01;33m[\w]\033[00m\n\033[0;90m\$ "

wrapping the format code in [] ensures that annoying behavior never happens:

export PS1="\n\[\[\033[01;33m\][\w]\[\033[00m\]\n\[\033[0;90m\]\$ "

The documentation: http://tldp.org/HOWTO/Bash-Prompt-HOWTO/nonprintingchars.html

Since PS1 formatting causes the value to be so long and hard to read I put the format codes in variables:

BYELLOW='\[\033[01;33m\]'
IBLACK='\[\033[0;90m\]'
PS_CLEAR='\[\033[0m\]'
export PS1="\n${BYELLOW}[\w]${PS_CLEAR}\n${IBLACK}\$ "
m79lkm
  • 701
10

I had the same problem and it was related to the color definitions.

In my case, I have a multi-line prompt (gives most space for current command regardless of path length displayed by prompt).

Bad version:

export PS1="\n\n\[\033[01;33m[\w]\n\033[00m\$ "

Good version:

export PS1="\n\n\[\033[01;33m[\w]\033[00m\n\$ "

\033[00m terminates the color. If it is after the new line (\n), it prevents proper redraw in the terminal, to overwrite previous commands with background color. Moving it behind the new line resolved the problem.

(using Terminal in Mac OS 10.8)

Phreditor
  • 201
8

Somewhere your prompt is fubar. What usually happens is that your shell thinks its outputting non-printable term codes and expecting it to take up space. The best advice I can give you is to systematically add to (or take away from) your prompt until this behavior stops to isolate the code that is causing this issue.

SiegeX
  • 2,467
4

I actually think this has to do with a missing 'non-printing character' delimiter. I had exactly the same issue, but moving it before the newline (\n) didn't fix it. Instead I correctly surrounded all non-printing characters (here, colouring commands) with '\[' and '\]'.

Bad (works, but has the history-mashing problem described above):

PS1="\e[32m\u\e[35m@\e[32m\h \e[33m\w\e[36m\n\$\e[0m"

Good (surrounded all colour commands with '\[' and '\]' - does not show mashed command history):

PS1="\[\e[32m\]\u\[\e[35m\]@\[\e[32m\]\h \[\e[33m\]\w\[\e[36m\]\n\$\[\e[0m\]"

i.e. "\e[...m" --becomes--> "\[\e[...m\]"

And if you are putting this into something like SecureCRT to auto-send upon login to a system, you may have to double escape everything (put double backslashes everywhere) if auto-login system consumes the first backslash itself to determine the character to be sent:

PS1="\\[\\e[32m\\]\\u\\[\\e[35m\\]@\\[\\e[32m\\]\\h \\[\\e[33m\\]\\w\\[\\e[36m\\]\\n\\$\\[\\e[0m\\]"

i.e. "\..." --becomes--> "\\..."

(This is definitely true of SecureCRT and may be true of others, such as PuTTY or TeraTerm - testing required on your part.)

skeetastax
  • 261
1

I was with this issue. What i detected?

When you have colors inside PS1 variable (ex: "\e[35m" ) it ALWAYS have to be surrounded by "\[" and "\]" (ex: "\[\e[35m\]" ).

When i marked all colours in PS1 according to this rule, it worked!

No more problems with scrolling the history of bash.

BAD EXAMPLE: PS1="\e[0;36m[\u@\h[\e[1;31m$ORACLESID\e[0;36m] \W]\e[0m"; export PS1

GOOD EXAMPLE: PS1="\[\e[0;36m\][\u@\h[\[\e[1;31m\]$ORACLESID\[\e[0;36m\]]\W]\[\e[0m\] "; export PS1

lanzito
  • 11
  • 1
0

Building upon others answers, most likely there's some line in your .zshrc or .zshenv or somewhere else you edited is messing up your command line because it has the wrong syntax, usually a good place to start looking for the source of the issue is anything related to colors. For me it was this line:

PROMPT="$fg[blue]%}myhostrname ${PROMPT}"

When I properly wrapped $fg[blue] inside %{$fg[blue]%} like so:

PROMPT="%{$fg[blue]%}myhostrname ${PROMPT}"

It was fixed.

Context: Zsh theme I was using didn't display the host's name on the terminal so I hardcoded it via this command, but I missed up the color's syntax which caused the command line to freak out with unexpected behavior on several occasions. Been like that for a year or so and I only finally decided to fix it lol.

Toto
  • 19,304
M.Ed
  • 101
0

In my case, I wrote a Perl script to dinamically change the folders in prompt to "something shorter". The script was successful, prompt get updated automatically when cd, but if I navigated history (with arrow up/down), history used to overwrite one part of the new prompt. The ugly part of this issue is that the command line doesn't get cleared by moving through history, so one "short history" could apear INSIDE a previous "printed" PS1.

The solution is in the end.

My conclusions were two:

1- Dynamic PS1 with \[`executables`\] in the PS1 body are not guaranteed to keep the size when navigating history, because it seems that history forces to 2 characters margin in the left (maybe related to an ancester "$_" prompt)

2- To have an immutable length prompt, PS1 must be a fixed size string. Documentation allows to use \[ and \] where I ran a dynamic code inside to transform \w, but it presented that weakness.

Here is a nice example of fixed size PS1:

export PS1='\[\033[01;32m\]\u\[\033[00m\]:\[\033[01;36m\]\w\[\033[00m\]\$ '

My solution:

I rewrote the cd function in a file that is executable and sourced in both .profile and .bashrc.

This function then exports the new FIXED SIZE PS1 exactly in the change of pwd. Now history is NOT messing the prompt because the PS1 body has no longer dynamic parts. I execute the script out and concatenate the result, generating a new fixed size PS1 to export.

function cd {
    MYDIR="${1:-${HOME}}"
    builtin cd "${MYDIR}"
    # echo 'from generic cd'
    export PWD=`pwd` 
    #Dynamic script invoked out of PS1:
    folders=`getPs1`
    export PS1='\[\033[01;36m\]'$folders'\[\033[00m\]\$ ' 
}
Sergio Abreu
  • 171