Normally when I save a password in Safari it will get added to my login keychain without fuss (assuming that it is already unlocked). But after I set a a master password the default keychain was changed to FileVaultMaster. When I set it back to login Safari then started to always ask for permission to access the keychain.
To get it back to the default behavior should I chose always allow or is there something else I should do?
Yes, if you press Always Allow would put it back to it's default behaviour otherwise it will ask you to access the Keychain each time. By pressing Allow you tell the security system to allow Safari to access it once and only once, if you say Always Allow you say it can access it from now on until it is updated again. (Developers have an option to avoid this issue by signing their applications)
You have two potential problems. The first is that your default keychain is no longer set to "login". Open up Keychain Access (/Applications/Utilities/Keychain Access.app), select the login keychain, and choose File » Make Keychain "login" Default.
The second potential problem is a damaged keychain. In Keychain Access, still with the login keychain selected, choose Keychain Access » Keychain First Aid. Enter your password and hit repair.
I've had about the same problem and it has everything to do with Code Signing. There are complex ways to change the Safari code signing, so take the easy way: just put you Safari application in the trash can and copy the complete (working) Safari application from another Mac (with the same version number) to yours.
Keychain Access will ask you for permission. Choose "always" and you're problem is fixed!
It did the trick for me after Googling and troubleshooting for hours...
I've had this problem with my Aunt's 2010 iMac; she forgot the master password and I performed a reset using the install disk. However, since then she has been plagued by the same issue detailed above, repeated requests for password. I finally had a chance to go to the Apple Genius bar having exhausted all discussion forums to no avail and was given an as yet unproven solution. The guy says he gets this problem all the time and he was pretty confident it would work.
As follows:
I will update this post on attempting this fix; it sounds logical though. Anyone who has success, feel free to chime in. I should also point out that this will obviously wipe any application/web passwords you already have saved but I don't think that should be an issue for most people.
Update: It worked, so far so good! Can't believe the solution was so simple!
Though given your description I doubt it's the case, but maybe the digital signature of Safari itself is broken? You can test it using:
codesign --verify --verbose /Applications/Safari.app
...which should give you:
/Applications/Safari.app: valid on disk /Applications/Safari.app: satisfies its Designated Requirement
(And if indeed it's broken, then see If Mac code signing is tampered with, what might fail?)
It may have also become out sync with your login account. By default regular keychain first aid won't fix it. To make it check and fix it, open Keychain Access.app, click the Keychain Access menu and open preferences. Hit the 'First Aid' tab and tick the 'Synchronise login keychain password with account' box.
Then run keychain first aid again.
